Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new tool: immortal-cravings #1301

Merged
merged 5 commits into from
Nov 12, 2024
Merged

new tool: immortal-cravings #1301

merged 5 commits into from
Nov 12, 2024

Conversation

chdoc
Copy link
Member

@chdoc chdoc commented Sep 12, 2024

allow immortals to satisfy their cravings for food and drink

@myk002
Copy link
Member

myk002 commented Sep 13, 2024

this is an awesome name : D

however, I am seeing a parallel with the concept of idle-crafting I think it would be better to combine those tools into one script, and as we add more kinds of self-service autonomy, they can become features of the unified script instead of creating a new script for each one.

Would it make sense to rename idle-crafting to autonomy or i-want-it-i-do-it or something that encompasses these related ideas?

@chdoc
Copy link
Member Author

chdoc commented Sep 15, 2024

I'm not entirely sure. There obviously are parallels, but idle-crafting is (essentially) an automation tool while this one is clearly in the "gameplay" category. From the implementation perspective, I would have to think about where the synergies really are - apart from a shared main loop where units with needs get picked up. I don't see a natural place to configure this tool using an overlay.

From the communication perspective, idle-crafting has just been announced as a feature and received a lot of positive attention. I'm not sure immediately renaming it is a good idea.

From the development perspective, every need that we satisfy using a tool requires some amount of research and discussion. And other needs may require entirely different techniques. So maybe it is good to keep this thing separate for now.

Ultimately, I expect idle-crafting and related tools to be re-implemented as a C++ plugin at some point. idle-crafting currently takes about 0.7% of CPU time in my forts. Not an immediate problem, but still consuming about 7% of the total DFHack allowance. This tools time usage is hardly measurable in forts with one or two resident necromancers.

changelog.txt Outdated Show resolved Hide resolved
docs/immortal-cravings.rst Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also add this tool to the control panel registry (internal/control-panel/registry.lua)?

immortal-cravings.lua Show resolved Hide resolved
immortal-cravings.lua Outdated Show resolved Hide resolved
immortal-cravings.lua Outdated Show resolved Hide resolved
immortal-cravings.lua Outdated Show resolved Hide resolved
immortal-cravings.lua Outdated Show resolved Hide resolved
immortal-cravings.lua Outdated Show resolved Hide resolved
immortal-cravings.lua Show resolved Hide resolved
@chdoc
Copy link
Member Author

chdoc commented Oct 2, 2024

It may take until the next weekend for me to get back to this. Busy at work and other plans for the upcoming weekend.

@myk002
Copy link
Member

myk002 commented Oct 2, 2024

no hurry! I have plenty of other PRs to keep me busy

Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add immortal-cravings to the control panel registry (internal/control-panel/registry.lua)?

Also, could you add a line to the New Tools section of the changelog? edit: didn't see that you already did

docs/immortal-cravings.rst Outdated Show resolved Hide resolved
@myk002 myk002 merged commit 80e1a98 into DFHack:master Nov 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants